Fix 6428/chat open on clicking dropdown #6429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
The pull request addresses the issue of the chat opening when clicking the dropdown by replacing the SupportChat component with the SupportDropdown component and making related updates.
- AppNavigationDrawer.tsx: Replaced
SupportChatwithSupportDropdownin the navigation drawer footer. - SupportButton.tsx: Renamed from
SupportChat, addedisClickAbleprop, and updated the onClick handler. - SupportButtonSkeletonLoader.tsx: Renamed from
SupportChatSkeletonLoaderfor clarity. - SupportDropdown.tsx: Introduced a new
SupportDropdowncomponent with options for 'Talk to us' and 'Documentation'. - SettingsBilling.tsx: Replaced
SupportChatwithSupportButtonand set it todisplay: noneto prevent interference.
7 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings
| dropdownId={dropdownId} | ||
| dropdownPlacement="top-start" | ||
| dropdownOffset={{ x: 0, y: -28 }} | ||
| clickableComponent={<SupportButton isClickAble={false} />} |
There was a problem hiding this comment.
Style: Consider renaming isClickAble to isClickable for consistency.
|
Thanks @NitinPSingh for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This issue was caused due to last comomit on issue by me only fix_6127/support_button_updated
I had fixed the chat opening problem , in this commit