fix #6127 updated support button #6422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Updated the Support button to open a dropdown menu with options to access the user guide or contact support through chat.
- AppNavigationDrawer.tsx: Replaced
SupportChatwithSupportDropdownin the navigation drawer's footer. - SupportDropdown.tsx: Introduced a new dropdown menu for the support button, using
DropdownandMenuItemcomponents. - SupportChat.stories.tsx: Added user interaction tests to verify the new dropdown menu options 'Documentation' and 'Talk to us'.
3 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
| @@ -48,5 +48,8 @@ export const Default: Story = { | |||
| play: async () => { | |||
| const canvas = within(document.body); | |||
| expect(await canvas.findByText('Support')).toBeInTheDocument(); | |||
| await userEvent.click(canvas.getByText('Support')); | |||
There was a problem hiding this comment.
this looks more like a SupportDropdown test than a SupportChat test, we would need both!
There was a problem hiding this comment.
HI @NitinPSingh, thanks a lot for the pull request!
Here are my feedbacks:
- SupportChat should be renamed to SupportButton
- add a story for SupportDropdown and delete the one about SupportChat (or re-use it) to test the whole behavior (open dropdown, then open support chat)
- the dropdown is not opening exactly like specified on the ticket, it's a bit too up
|
Also, make sure to fix the lint :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #6127
updated the Support button toopen a menu that allows users to either access the user guide or contact support through the chat.