Put workfows behind a feature flag #6417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
The pull request introduces feature flags to control the availability of workflow-related features, ensuring better feature management and rollout control.
- Feature Flag Integration: Added feature flag checks for
workflowandworkflowIdfields in multiple workspace entity classes (activity-target.workspace-entity.ts,attachment.workspace-entity.ts,favorite.workspace-entity.ts). - Decorator Adjustment: Moved
@WorkspaceGatedecorator inworkflow-version.workspace-entity.tsandworkflow.workspace-entity.tsto ensure correct feature flag application. - Conditional Metadata: Introduced feature flag checks in
standard-index.factory.tsto conditionally include/exclude index metadata. - Seeding Functionality Disabled: Commented out significant code block in
data-seed-dev-workspace.command.ts, impacting development workflows that rely on seeded data.
7 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
charlesBochet
deleted the
fix-tt-workflow-and-version-as-standard-objects
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have recently merged #workflow but we should put the workflow standard object behind a feature flag for now