Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix participant chip #6411

Merged
merged 2 commits into from
Jul 25, 2024
Merged

Fix participant chip #6411

merged 2 commits into from
Jul 25, 2024

Conversation

bosiraphael
Copy link
Contributor

@bosiraphael bosiraphael commented Jul 25, 2024

  • Fix gap
  • Modify query to retrieve person and workspaceMember to display a record chip inside the message right drawer

Before:
Capture d’écran 2024-07-25 à 17 14 57
Capture d’écran 2024-07-25 à 17 14 40

After:
Capture d’écran 2024-07-25 à 17 13 53
Capture d’écran 2024-07-25 à 17 14 18

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This pull request addresses visual and data retrieval improvements for the participant chip in the message right drawer.

  • Visual Enhancement: Added gap property to StyledChip in packages/twenty-front/src/modules/activities/components/ParticipantChip.tsx for better spacing and readability.
  • GraphQL Query Update: Enhanced query in packages/twenty-front/src/modules/activities/emails/graphql/operation-signatures/factories/fetchAllThreadMessagesOperationSignatureFactory.ts to include detailed participant information (id, role, displayName, person, workspaceMember).
  • Data Retrieval: The updated query now retrieves nested participant details, which could impact performance if not managed properly.

2 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings

@lucasbordeau lucasbordeau merged commit b311531 into main Jul 25, 2024
13 checks passed
@lucasbordeau lucasbordeau deleted the r-fix-participant-chip branch July 25, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants