-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
6255 move services from messaging common module into the correct module and refactor them #6409
Merged
charlesBochet
merged 19 commits into
main
from
6255-move-services-from-messaging-common-module-into-the-correct-module-and-refactor-them
Jul 27, 2024
Merged
Changes from 15 commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
9d040e3
move files
bosiraphael c18f1af
move constants
bosiraphael 0d1ca5b
remove AddPersonIdAndWorkspaceMemberIdService
bosiraphael 7bb55e2
fix contact matching bug on calendar events
bosiraphael 708b747
fix participants matching for calendar events
bosiraphael 0a3d14d
add transactionManager to matchCalendarEventParticipants
bosiraphael 1354598
renaming
bosiraphael 674f4c8
update matchMessageParticipants
bosiraphael b2114d6
update participant matching for messaging-message-participant.service
bosiraphael 3aa29c8
rename
bosiraphael ec00baa
fix matching
bosiraphael a121121
fix
bosiraphael 36aedaa
reorganise and rename files
bosiraphael d787d44
move telemetry service inside monitoring module
bosiraphael 61afcfb
Merge branch 'main' into 6255-move-services-from-messaging-common-mod…
charlesBochet 997e771
modifications after review
bosiraphael 435ebfe
remove calendar common module
bosiraphael b03333a
remove duplicated logic
bosiraphael 3ce6685
fix matching
bosiraphael File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
2 changes: 1 addition & 1 deletion
2
...tests__/is-email-blocklisted.util.spec.ts → ...tests__/is-email-blocklisted.util.spec.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
92 changes: 0 additions & 92 deletions
92
...es/add-person-id-and-workspace-member-id/add-person-id-and-workspace-member-id.service.ts
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
...odules/calendar/calendar-event-import-manager/utils/filter-out-blocklisted-events.util.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 changes: 1 addition & 2 deletions
3
packages/twenty-server/src/modules/calendar/common/calendar-common.module.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,11 +1,10 @@ | ||
import { Module } from '@nestjs/common'; | ||
|
||
import { WorkspaceDataSourceModule } from 'src/engine/workspace-datasource/workspace-datasource.module'; | ||
import { AddPersonIdAndWorkspaceMemberIdService } from 'src/modules/calendar-messaging-participant-manager/services/add-person-id-and-workspace-member-id/add-person-id-and-workspace-member-id.service'; | ||
|
||
@Module({ | ||
imports: [WorkspaceDataSourceModule], | ||
providers: [AddPersonIdAndWorkspaceMemberIdService], | ||
providers: [], | ||
exports: [], | ||
}) | ||
export class CalendarCommonModule {} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. do we still need this one? looks like nothing is provided or exported |
2 changes: 1 addition & 1 deletion
2
packages/twenty-server/src/modules/connected-account/utils/is-throttled.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
File renamed without changes.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think you have to pass the workspaceId here, you could get it from the scopedWorkspaceContextFactory (see twenty-orm.manager.ts). This would avoid the whole drill down and secure the behavior to avoid proposing where the workspace can be provided. That's being said I'm not 100% sure about this pattern of auto-resolving the workspaceId from the request
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done