Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent field with null standardId to be considered as field identifier #6407

Merged
merged 1 commit into from
Jul 25, 2024

Conversation

charlesBochet
Copy link
Member

Otherwise, any custom field will be considered as image/label identifier by the sync-metadata scripts

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

The changes ensure fields with a null standardId are not considered as field identifiers, preventing custom fields from being misidentified by sync-metadata scripts.

  • Modified packages/twenty-server/src/engine/workspace-manager/workspace-sync-metadata/services/workspace-sync-object-metadata-identifiers.service.ts to add a condition in the find method to check that field.standardId is not null.
  • This prevents custom fields from being mistakenly identified as image or label identifiers.
  • Ensures accurate synchronization of metadata by excluding fields with null standardId.

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings

@charlesBochet charlesBochet merged commit d073ebf into main Jul 25, 2024
6 checks passed
@charlesBochet charlesBochet deleted the field-identifier-no-null branch July 25, 2024 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants