Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix api timeout #6401

Merged
merged 2 commits into from
Jul 25, 2024
Merged

Fix api timeout #6401

merged 2 commits into from
Jul 25, 2024

Conversation

martmull
Copy link
Contributor

  • Set default depth to 1
  • Improve query read timeout message

@martmull martmull marked this pull request as ready for review July 25, 2024 06:30
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

The pull request addresses API timeout issues by refining error messages and adjusting default query depth values.

  • Updated packages/twenty-server/src/engine/api/graphql/workspace-query-runner/workspace-query-runner.service.ts to improve SQL query timeout error messages, providing actionable advice.
  • Changed DEFAULT_DEPTH_VALUE from 2 to 1 in packages/twenty-server/src/engine/api/rest/core/query-builder/utils/map-field-metadata-to-graphql-query.utils.ts to reduce query complexity.
  • Set default 'depth' parameter to 1 in packages/twenty-server/src/engine/core-modules/open-api/utils/__tests__/parameters.utils.spec.ts and packages/twenty-server/src/engine/core-modules/open-api/utils/parameters.utils.ts to ensure consistent default behavior.

4 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings

@martmull martmull merged commit 7c6ca0e into main Jul 25, 2024
6 checks passed
@martmull martmull deleted the fix-api-timeout branch July 25, 2024 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants