Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serverless function UI #6388

Merged
merged 50 commits into from
Jul 29, 2024
Merged

Serverless function UI #6388

merged 50 commits into from
Jul 29, 2024

Conversation

martmull
Copy link
Contributor

@martmull martmull commented Jul 24, 2024

https://www.figma.com/design/xt8O9mFeLl46C5InWwoMrN/Twenty?node-id=36235-120877

Did not do the file manager part. A Function is defined using one unique file at the moment

Feature protected by featureFlag IS_FUNCTION_SETTINGS_ENABLED

Demo

serverless.mov

@martmull martmull force-pushed the serverless-function-ui branch from fab2b45 to 9e0ce7f Compare July 24, 2024 13:59
@martmull martmull marked this pull request as ready for review July 24, 2024 14:09
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This pull request introduces a comprehensive serverless function UI, integrating new routes, components, and GraphQL operations to manage serverless functions within the application.

  • New Routes: Added routes in packages/twenty-front/src/App.tsx for managing serverless functions.
  • GraphQL Operations: Updated packages/twenty-front/src/generated-metadata/gql.ts and graphql.ts to include new operations for serverless functions.
  • UI Components: Introduced several new components in packages/twenty-front/src/modules/settings/serverless-functions/components/ for creating, editing, and listing serverless functions.
  • Custom Hooks: Added custom hooks in packages/twenty-front/src/modules/settings/serverless-functions/hooks/ for GraphQL mutations and queries related to serverless functions.
  • Utility Function Refactor: Replaced hardcoded URLs with getFileAbsoluteURI in multiple files for better maintainability.

30 file(s) reviewed, 2 comment(s)
Edit PR Review Bot Settings

return (
<StyledApisFieldTableRow to={to}>
<StyledNameTableCell>{serverlessFunction.name}</StyledNameTableCell>
<StyledNameTableCell>{serverlessFunction.runtime}</StyledNameTableCell>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style: Potential issue: Reusing StyledNameTableCell for runtime might cause confusion. Consider renaming or creating a separate styled component.

@martmull martmull force-pushed the serverless-function-ui branch from 2230397 to 55ccf0f Compare July 25, 2024 16:04
@martmull martmull force-pushed the serverless-function-ui branch from 818af3e to f82e32d Compare July 26, 2024 14:18
@martmull martmull force-pushed the serverless-function-ui branch from f82e32d to b5ad157 Compare July 26, 2024 14:40
@martmull martmull force-pushed the serverless-function-ui branch from 10e40db to 57e71c2 Compare July 26, 2024 15:14
@martmull martmull force-pushed the serverless-function-ui branch from 00f6c64 to a7342e7 Compare July 29, 2024 07:35
@martmull martmull force-pushed the serverless-function-ui branch 6 times, most recently from 561fdf0 to 29d8348 Compare July 29, 2024 10:22
@martmull martmull force-pushed the serverless-function-ui branch from 29d8348 to 007d928 Compare July 29, 2024 10:50
@martmull martmull merged commit 00fea17 into main Jul 29, 2024
14 checks passed
@martmull martmull deleted the serverless-function-ui branch July 29, 2024 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants