Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] Migrated links field should be standard #6387

Merged
merged 1 commit into from
Jul 24, 2024

Conversation

ijreilly
Copy link
Collaborator

Fixing script + ading logs to sync-metadata

@@ -225,6 +225,7 @@ export class MigrateLinkFieldsToLinksCommand extends CommandRunner {
id: tmpNewLinksField.id,
workspaceId: tmpNewLinksField.workspaceId,
name: `${fieldName}`,
isCustom: false,
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when using the service, create endpoint overrides input value for isCustom, but update does not

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

The pull request focuses on fixing the script and adding logs to the sync-metadata process to ensure the migrated links field is standardized.

  • File: packages/twenty-server/src/database/commands/upgrade-version/0-23/0-23-migrate-link-fields-to-links.command.ts

    • Added isCustom: false to mark migrated fields as standard.
    • Enhanced logging for better migration visibility.
  • File: packages/twenty-server/src/engine/workspace-manager/workspace-sync-metadata/commands/sync-workspace-metadata.command.ts

    • Added logging statements to improve traceability during workspace synchronization.

Ensure the isCustom property is correctly handled across all related services and thoroughly test the migration script to avoid data inconsistencies.

2 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings

Copy link
Member

@charlesBochet charlesBochet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ijreilly ijreilly merged commit 082d55b into main Jul 24, 2024
6 checks passed
@ijreilly ijreilly deleted the fix-sync-workspace-metadata branch July 24, 2024 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants