Fix RecordTableHeaderCell #6383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Refactored RecordTableHeaderCheckboxColumn.tsx to use styled components, addressing the background color issue and improving maintainability.
- Introduced
StyledColumnHeaderCellinpackages/twenty-front/src/modules/object-record/record-table/record-table-header/components/RecordTableHeaderCheckboxColumn.tsxfor consistent styling. - Removed
useThemehook as it's redundant with styled components. - Ensured visual consistency across themes and screen sizes by encapsulating styles within styled components.
- Verified that the background color is now correctly applied, resolving issue Fix RecordTableHeaderCell #6365.
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
Welcome!
Hello there, congrats on your first PR! We're excited to have you contributing to this project. |
charlesBochet
approved these changes
Jul 24, 2024
lucasbordeau
pushed a commit
to AdityaPimpalkar/twenty
that referenced
this pull request
Jul 24, 2024
@Bonapara Fixed! the issue (twentyhq#6365) where the `background-color` style was not set, causing the bug. Now, the background color is properly applied. https://github.com/user-attachments/assets/668bd3cc-77ea-42a9-84d4-071fca497e07
|
Fixes #6365 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6365
@Bonapara
Fixed! the issue (#6365) where the
background-colorstyle was not set, causing the bug. Now, the background color is properly applied.2024-07-23.22-31-58.mp4