Use LinksMetadata right type for Links fields #6380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Updated the type of several fields from LinkMetadata to LinksMetadata to handle multiple links, ensuring consistency and correctness in the data model.
- calendar-event.workspace-entity.ts: Updated
conferenceLinkfield type toLinksMetadata. - company.workspace-entity.ts: Updated
linkedinLinkandxLinkfields toLinksMetadata. - person.workspace-entity.ts: Updated
linkedinLinkandxLinkfields toLinksMetadata.
These changes align the fields with the updated metadata type definitions, preventing potential runtime errors related to type mismatches.
3 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
charlesBochet
approved these changes
Jul 23, 2024
lucasbordeau
pushed a commit
to AdityaPimpalkar/twenty
that referenced
this pull request
Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.