Simplify ORM #6373
Merged
Simplify ORM #6373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR refactors the ORM-Manager to simplify and unify the datasource creation process.
- Removed outdated upgrade commands and modules in
packages/twenty-server/src/database/commands/upgrade-version/0-22/. - Refactored
workspace-datasource.factory.tsto introduce caching mechanisms for workspace data sources. - Updated
google-apis.service.tsto dynamically obtain the workspace data source usingTwentyORMManager. - Deleted
inject-workspace-datasource.decorator.tsandinject-workspace-repository.decorator.tsto streamline dependency injection. - Modified
twenty-orm.manager.tsto consolidate repository and datasource retrieval logic.
23 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings
Comment on lines
+18
to
21
| const workspaceDataSource = await this.workspaceDataSourceFactory.create( | ||
| workspaceId, | ||
| null, | ||
| ); |
There was a problem hiding this comment.
Logic: Potential issue: Removing cache version handling might affect performance and data consistency.
|
I tested the messages and calendar syncs for this PR and it works well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the ORM-Manager to simplify and unify the datasource creation. I'm deprecating all usages if InjectWorkspaceDatasource and InjectWorkspaceRepository as we can't be sure they are up-to-date