Webhook wip #6371
Merged
Webhook wip #6371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This pull request introduces a new section for filtering webhook events and reorganizes import statements in a specific file.
- Reorganized Imports:
packages/twenty-front/src/modules/settings/data-model/fields/forms/components/SettingsDataModelFieldTypeSelect.tsx- Reordered import statements, no functional changes. - Webhook Event Filtering:
packages/twenty-front/src/pages/settings/developers/webhooks/SettingsDevelopersWebhookDetail.tsx- Added aSelectcomponent for filtering webhook events. - New Hook Integration:
packages/twenty-front/src/pages/settings/developers/webhooks/SettingsDevelopersWebhookDetail.tsx- IntroduceduseUpdateOneRecordhook to update webhook operations based on selected filters. - Potential Pitfalls: Ensure
updateOneRecordfunction works correctly andobjectMetadataItemsare properly fetched and mapped. Thorough testing is recommended.
2 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
charlesBochet
commented
Aug 5, 2024
| @@ -4,7 +4,6 @@ import { Link } from 'react-router-dom'; | |||
|
|
|||
| const StyledUndecoratedLink = styled(Link)` | |||
| text-decoration: none; | |||
| width: 100%; | |||
There was a problem hiding this comment.
regression introduced in a recent PR
charlesBochet
commented
Aug 5, 2024
| @@ -89,7 +89,7 @@ export class WorkspaceMigrationRunnerService { | |||
|
|
|||
| await queryRunner.commitTransaction(); | |||
| } catch (error) { | |||
| this.logger.error('Error executing migration', error); | |||
| console.error('Error executing migration', error); | |||
There was a problem hiding this comment.
logger swallow the errors too much which is a problem to troubleshoot in prod
Weiko
approved these changes
Aug 5, 2024
There was a problem hiding this comment.
What happens if an object is deleted? Should we delete associated webhooks? Should we add a "isDeactivated" bool on the webhook and invalidate it until the user update it? Otherwise LGTM! @charlesBochet
|
FYI @FelixMalfait |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the following changes: