Lumosviridi v20 kubernetes updates #6356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactored to use vars instead of locals Added variable descriptions Misc bug fixed for terraform
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This pull request introduces updates for v20+ and various Terraform bug fixes, focusing on improving readability and ease of use by replacing local variables with Terraform input variables.
- New Kubernetes Deployment: Added
packages/twenty-docker/k8s/manifests/deployment-worker.yamlfor thetwentycrm-workercomponent. - Environment Variables: Updated
packages/twenty-docker/k8s/manifests/deployment-server.yamlto include new environment variables (FRONT_BASE_URL,BACKEND_SERVER_URL,MESSAGE_QUEUE_TYPE). - Terraform Refactor: Replaced local variables with input variables across multiple Terraform files (
deployment-db.tf,deployment-server.tf,variables.tf). - Documentation: Added
packages/twenty-docker/k8s/terraform/.terraform-docs.ymland updatedREADME.mdto auto-generate documentation usingterraform-docs. - Version Updates: Updated required Terraform version to
>= 1.9.2and Kubernetes provider version to>= 2.31.0inmain.tf.
19 file(s) reviewed, 7 comment(s)
Edit PR Review Bot Settings
|
|
||
| | Name | Description | Type | Default | Required | | ||
| |------|-------------|------|---------|:--------:| | ||
| | <a name="input_twentycrm_app_hostname"></a> [twentycrm\_app\_hostname](#input\_twentycrm\_app\_hostname) | The protocol, DNS fully qualified hostname, and port used to access TwentyCRM in your environemnt. Ex: https://crm.example.com:443 | `string` | n/a | yes | |
There was a problem hiding this comment.
Spelling: Typo in 'environment'.
Suggested change
| | <a name="input_twentycrm_app_hostname"></a> [twentycrm\_app\_hostname](#input\_twentycrm\_app\_hostname) | The protocol, DNS fully qualified hostname, and port used to access TwentyCRM in your environemnt. Ex: https://crm.example.com:443 | `string` | n/a | yes | | |
| The protocol, DNS fully qualified hostname, and port used to access TwentyCRM in your environment. Ex: https://crm.example.com:443 |
| | <a name="input_twentycrm_token_refreshToken"></a> [twentycrm\_token\_refreshToken](#input\_twentycrm\_token\_refreshToken) | TwentyCRM refresh Token | `string` | n/a | yes | | ||
| | <a name="input_twentycrm_app_name"></a> [twentycrm\_app\_name](#input\_twentycrm\_app\_name) | A friendly name prefix to use for every component deployed. | `string` | `"twentycrm"` | no | | ||
| | <a name="input_twentycrm_db_image"></a> [twentycrm\_db\_image](#input\_twentycrm\_db\_image) | TwentyCRM image for database deployment. This defaults to latest. | `string` | `"twentycrm/twenty-postgres:latest"` | no | | ||
| | <a name="input_twentycrm_db_pv_capacity"></a> [twentycrm\_db\_pv\_capacity](#input\_twentycrm\_db\_pv\_capacity) | Storage capacity provisioned for database persistant volume. | `string` | `"10Gi"` | no | |
There was a problem hiding this comment.
Spelling: Typo in 'persistent'.
Suggested change
| | <a name="input_twentycrm_db_pv_capacity"></a> [twentycrm\_db\_pv\_capacity](#input\_twentycrm\_db\_pv\_capacity) | Storage capacity provisioned for database persistant volume. | `string` | `"10Gi"` | no | | |
| Storage capacity provisioned for database persistent volume. |
| | <a name="input_twentycrm_db_image"></a> [twentycrm\_db\_image](#input\_twentycrm\_db\_image) | TwentyCRM image for database deployment. This defaults to latest. | `string` | `"twentycrm/twenty-postgres:latest"` | no | | ||
| | <a name="input_twentycrm_db_pv_capacity"></a> [twentycrm\_db\_pv\_capacity](#input\_twentycrm\_db\_pv\_capacity) | Storage capacity provisioned for database persistant volume. | `string` | `"10Gi"` | no | | ||
| | <a name="input_twentycrm_db_pv_path"></a> [twentycrm\_db\_pv\_path](#input\_twentycrm\_db\_pv\_path) | Local path to use to store the physical volume if using local storage on nodes. | `string` | `""` | no | | ||
| | <a name="input_twentycrm_db_pvc_requests"></a> [twentycrm\_db\_pvc\_requests](#input\_twentycrm\_db\_pvc\_requests) | Storage capacity reservation for database persistant volume claim. | `string` | `"10Gi"` | no | |
There was a problem hiding this comment.
Spelling: Typo in 'persistent'.
Suggested change
| | <a name="input_twentycrm_db_pvc_requests"></a> [twentycrm\_db\_pvc\_requests](#input\_twentycrm\_db\_pvc\_requests) | Storage capacity reservation for database persistant volume claim. | `string` | `"10Gi"` | no | | |
| Storage capacity reservation for database persistent volume claim. |
| | <a name="input_twentycrm_namespace"></a> [twentycrm\_namespace](#input\_twentycrm\_namespace) | Namespace for all TwentyCRM resources | `string` | `"twentycrm"` | no | | ||
| | <a name="input_twentycrm_server_data_mount_path"></a> [twentycrm\_server\_data\_mount\_path](#input\_twentycrm\_server\_data\_mount\_path) | TwentyCRM mount path for servers application data. Defaults to '/app/docker-data'. | `string` | `"/app/docker-data"` | no | | ||
| | <a name="input_twentycrm_server_image"></a> [twentycrm\_server\_image](#input\_twentycrm\_server\_image) | TwentyCRM server image for the server deployment. This defaults to latest. This value is also used for the workers image. | `string` | `"twentycrm/twenty:latest"` | no | | ||
| | <a name="input_twentycrm_server_pv_capacity"></a> [twentycrm\_server\_pv\_capacity](#input\_twentycrm\_server\_pv\_capacity) | Storage capacity provisioned for server persistant volume. | `string` | `"10Gi"` | no | |
There was a problem hiding this comment.
Spelling: Typo in 'persistent'.
Suggested change
| | <a name="input_twentycrm_server_pv_capacity"></a> [twentycrm\_server\_pv\_capacity](#input\_twentycrm\_server\_pv\_capacity) | Storage capacity provisioned for server persistant volume. | `string` | `"10Gi"` | no | | |
| Storage capacity provisioned for server persistent volume. |
| | <a name="input_twentycrm_server_image"></a> [twentycrm\_server\_image](#input\_twentycrm\_server\_image) | TwentyCRM server image for the server deployment. This defaults to latest. This value is also used for the workers image. | `string` | `"twentycrm/twenty:latest"` | no | | ||
| | <a name="input_twentycrm_server_pv_capacity"></a> [twentycrm\_server\_pv\_capacity](#input\_twentycrm\_server\_pv\_capacity) | Storage capacity provisioned for server persistant volume. | `string` | `"10Gi"` | no | | ||
| | <a name="input_twentycrm_server_pv_path"></a> [twentycrm\_server\_pv\_path](#input\_twentycrm\_server\_pv\_path) | Local path to use to store the physical volume if using local storage on nodes. | `string` | `""` | no | | ||
| | <a name="input_twentycrm_server_pvc_requests"></a> [twentycrm\_server\_pvc\_requests](#input\_twentycrm\_server\_pvc\_requests) | Storage capacity reservation for server persistant volume claim. | `string` | `"10Gi"` | no | |
There was a problem hiding this comment.
Spelling: Typo in 'persistent'.
Suggested change
| | <a name="input_twentycrm_server_pvc_requests"></a> [twentycrm\_server\_pvc\_requests](#input\_twentycrm\_server\_pvc\_requests) | Storage capacity reservation for server persistant volume claim. | `string` | `"10Gi"` | no | | |
| Storage capacity reservation for server persistent volume claim. |
charlesBochet
approved these changes
Jul 26, 2024
| @@ -76,7 +82,7 @@ spec: | |||
| stdin: true | |||
| tty: true | |||
| volumeMounts: | |||
| - mountPath: /app/.local-storage | |||
There was a problem hiding this comment.
we actually need both: .local-storage and docker-data
|
Thanks @LumosViridi for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates for v20+ and misc terraform bug fixes. Also refactored to use terraform variables instead of locals which helps with readability and ease of use for new users.
Terraform validation is currently passing:
Additionally added terraform-docs to generate a more helpful README for terraform specific configuration.
Raw K8s manifests were updated with changes for v20+ as well.