New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate inject workspace repo #6353

Merged

charlesBochet merged 2 commits into main from deprecate-inject-workspace-repo

Jul 19, 2024

Member

charlesBochet commented Jul 19, 2024 •

edited

Loading

In this PR, I'm:

removing @InjectWorkspaceRepository, as repository should be dynamically computed based on metadata, we cannot instantiate these repositories. While resolving the dependency injection, we would need to query the database which is not acceptable
simplifying entitySchemaFactory signature to always take an objectMetadata
updating usages

charlesBochet added 2 commits

July 20, 2024 00:34


          Deprecate @InjectWorkspaceRepository

a57aa86

Fix

3ec66fe

charlesBochet merged commit d8cadad into main

6 checks passed

charlesBochet deleted the deprecate-inject-workspace-repo branch

July 19, 2024 22:43

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet