Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Datamodel overview show other fields #6352

Merged
merged 3 commits into from
Jul 22, 2024

Conversation

brendanlaschke
Copy link
Contributor

Bildschirmfoto 2024-07-19 um 23 49 00

@ijreilly ijreilly self-assigned this Jul 22, 2024
Copy link
Collaborator

@ijreilly ijreilly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@brendanlaschke thanks again for the great work!!
How would you feel about replacing field.name with field.label in the whole feature ?
I think this will make more sense as it will reflect what users get to see in the UI here, while for instance we transliterate field's labels to compute the name if the label contains non latin characters; so name would not make much sense here.

@brendanlaschke
Copy link
Contributor Author

Sure :) this makes more sense ...

@ijreilly
Copy link
Collaborator

@brendanlaschke thanks for your reactivity, i allowed myself to remove the capitalization too so that we keep the exact same format :)

@ijreilly ijreilly merged commit 01fe3b6 into twentyhq:main Jul 22, 2024
11 checks passed
Copy link

Thanks @brendanlaschke for your contribution!
This marks your 93rd PR on the repo. You're top 1% of all our contributors 🎉
See contributor page - Share on LinkedIn - Share on Twitter

Contributions

@brendanlaschke brendanlaschke deleted the data-overview-expand-fields branch August 1, 2024 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants