Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix task text overflow #6351

Merged
merged 1 commit into from
Jul 24, 2024
Merged

Fix task text overflow #6351

merged 1 commit into from
Jul 24, 2024

Conversation

brendanlaschke
Copy link
Contributor

closes #5552

Bildschirmfoto 2024-07-19 um 23 35 25

greptile-apps[bot]
greptile-apps bot reviewed Jul 19, 2024
View reviewed changes
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

  • Fixed task text overflow issue in task list
  • Ensured long text lines are truncated to maintain layout
  • Updated CSS for task text handling

No file(s) reviewed, no comment(s)
Edit PR Review Bot Settings

@ijreilly
Copy link
Collaborator

Hey @brendanlaschke thank you for your multiple contributions!!
just checked out your PR, looks much better - I just wonder if we wouldn't want to get rid of the scrolling behaviour and fix a maximum width instead - what do you think?

@ijreilly ijreilly self-assigned this Jul 22, 2024
@brendanlaschke
Copy link
Contributor Author

Hey @brendanlaschke thank you for your multiple contributions!! just checked out your PR, looks much better - I just wonder if we wouldn't want to get rid of the scrolling behaviour and fix a maximum width instead - what do you think?

Maybe im a bit confused but where is a scrolling behavior? For me the task row,task body and task text look all normal without scrolling?

@ijreilly
Copy link
Collaborator

@brendanlaschke sorry I meant to attach a recording but it didnt go through or I just forgot to:

scrolling.mov

@brendanlaschke
Copy link
Contributor Author

brendanlaschke commented Jul 23, 2024 •
edited
Loading

@brendanlaschke sorry I meant to attach a recording but it didnt go through or I just forgot to:

scrolling.mov

Oh i was on the /tasks page. But this is not a task specific problem instead its a regression on the layout on the object page ...

Bildschirmfoto 2024-07-23 um 11 39 29

@ijreilly
Copy link
Collaborator

I see - thanks :) merging !

@ijreilly ijreilly merged commit ea4d051 into twentyhq:main Jul 24, 2024
11 checks passed
@github-actions GitHub Actions
Copy link

Thanks @brendanlaschke for your contribution!
This marks your 93rd PR on the repo. You're top 1% of all our contributors 🎉
See contributor page - Share on LinkedIn - Share on Twitter

Contributions

lucasbordeau pushed a commit to AdityaPimpalkar/twenty that referenced this pull request Jul 24, 2024
@brendanlaschke @lucasbordeau
Fix task text overflow (twentyhq#6351)
c811e64 
closes twentyhq#5552

<img width="754" alt="Bildschirmfoto 2024-07-19 um 23 35 25"
src="https://github.com/user-attachments/assets/715192cd-679d-430a-95f1-8bc1d8fd26f4">
@brendanlaschke brendanlaschke deleted the fix-task-text-overflow branch August 1, 2024 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greptile-apps greptile-apps[bot] greptile-apps[bot] left review comments

@ijreilly ijreilly ijreilly approved these changes

Assignees

@ijreilly ijreilly

Labels
-PR: awaiting author
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Adding a task with attached text containing a long first line isn't truncated, and breaks layout
2 participants
@brendanlaschke @ijreilly