Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Record board columns design fix (full height borders) #6350

Merged
merged 1 commit into from
Jul 22, 2024
Merged

Conversation

gitstart-app[bot]
Copy link
Contributor

@gitstart-app gitstart-app bot commented Jul 19, 2024

This PR was created by GitStart to address the requirements from this ticket: TWNTY-5273.
This ticket was imported from: TWNTY-5273


Description:

  • We added a min-height to fix the main issue, in two components, one of them needs `calc` because the border causes the creation of a scrollbar
  • The change on the overflow fixes the issue mentioned here

Refs: #5273

Demo:


https://jam.dev/c/01cac1e5-ed66-439c-88fb-9406a06429c5

Fixes #5273

@ijreilly ijreilly merged commit 41931c5 into main Jul 22, 2024
13 checks passed
@ijreilly ijreilly deleted the TWNTY-5273 branch July 22, 2024 11:58
Copy link

Fails
🚫

node failed.

Log

�[31mError: �[39m SyntaxError: Unexpected end of JSON input
    at JSON.parse (<anonymous>)
�[90m    at parseJSONFromBytes (node:internal/deps/undici/undici:5584:19)�[39m
�[90m    at successSteps (node:internal/deps/undici/undici:5555:27)�[39m
�[90m    at fullyReadBody (node:internal/deps/undici/undici:1665:9)�[39m
�[90m    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)�[39m
�[90m    at async specConsumeBody (node:internal/deps/undici/undici:5564:7)�[39m
danger-results://tmp/danger-results-b34d3a24.json

Generated by 🚫 dangerJS against a3fe6aa

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Record board columns design fix (full height borders)
2 participants