Migrate fields of deprecated type LINK to type LINKS #6332
Conversation
| if (position > acc) { | ||
| return position; | ||
| } | ||
| if (!createdFieldIsAlreadyInView) { |
There was a problem hiding this comment.
Added this as we have no constraint elsewhere to forbid adding an already present field in a view - not sure if there is a usecase where that would make sense?
on my side I needed this in case of a rollback where we would restore the initial field by creating it again which would trigger the field's addition to the view, while it was still present in the view (from when it was originally created as we don't delete fields from viewFields when we delete the field - not sure why we don't do it?), creating a duplicated presence in the view.
There was a problem hiding this comment.
AFAIK adding the same field twice is currently not possible on frontend side. I guess that means we do not have any use case.
About your second question, I do we still see the viewFields when we delete le field currently? I don't get how this would work
ijreilly
changed the title
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
- Enhanced handling of view fields in
packages/twenty-server/src/engine/metadata-modules/field-metadata/field-metadata.service.ts - Added check to prevent duplicate field entries in views
- Used
lodash.isemptyto verify view existence - Imported
ViewFieldWorkspaceEntityfor typecasting view fields
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
| _passedParam: string[], | ||
| options: MigrateLinkFieldsToLinksCommandOptions, | ||
| ): Promise<void> { | ||
| this.logger.log('running'); |
There was a problem hiding this comment.
Maybe add a more explicit log?
There was a problem hiding this comment.
Or remove it since this is bellow already
| if (position > acc) { | ||
| return position; | ||
| } | ||
| if (!createdFieldIsAlreadyInView) { |
There was a problem hiding this comment.
AFAIK adding the same field twice is currently not possible on frontend side. I guess that means we do not have any use case.
About your second question, I do we still see the viewFields when we delete le field currently? I don't get how this would work
| private readonly logger = new Logger(ViewService.name); | ||
| constructor(private readonly twentyORMManager: TwentyORMManager) {} | ||
|
|
||
| async addFieldToViewsContainingOldField({ |
There was a problem hiding this comment.
IMO functions in services should be more generic. Input should be either:
addFieldToViews(workspaceId, newFieldId, viewFilter)
-addFieldToViews(workspaceId, newFieldId, views). Then you will need another functionfindViews(workspaceId, filter)
Closes #5909.
Adding a command to migrate fields of type Link to fields of type Links, including their data.