Add description for Developers/webhook page #6327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
- Added optional
descriptionfield toWebhooktype inpackages/twenty-front/src/modules/settings/developers/types/webhook/Webhook.ts - Updated
SettingsDevelopersWebhooksDetail.stories.tsxto includedescriptionin mock GraphQL response - Enhanced
SettingsDevelopersWebhookDetail.tsxto display webhook description - Added
descriptionfield to the new webhook form inSettingsDevelopersWebhooksNew.tsx - Updated
computeWebhooks.utils.tsandwebhook.workspace-entity.tsto supportdescriptionfield in webhook schema and entity
7 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings
packages/twenty-website/src/content/user-guide/functions/api-webhooks.mdx
Outdated
Show resolved
Hide resolved
thomtrp
requested changes
Jul 22, 2024
There was a problem hiding this comment.
@abdulqdaer-q thank you for contributing!
I added a few comments
packages/twenty-front/src/pages/settings/developers/webhooks/SettingsDevelopersWebhooksNew.tsx
Outdated
Show resolved
Hide resolved
packages/twenty-server/src/modules/webhook/standard-objects/webhook.workspace-entity.ts
Show resolved
Hide resolved
...ages/twenty-front/src/pages/settings/developers/webhooks/SettingsDevelopersWebhookDetail.tsx
Outdated
Show resolved
Hide resolved
packages/twenty-front/src/pages/settings/developers/webhooks/SettingsDevelopersWebhooksNew.tsx
Outdated
Show resolved
Hide resolved
|
@thomtrp Comments have been resolved |
thomtrp
force-pushed
the
add-title-for-webhook-6236
branch
from
d1137f8 to
588cccb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #6236