Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed scoped hotkeys #6322

Merged
merged 3 commits into from
Jul 19, 2024
Merged

Fixed scoped hotkeys #6322

merged 3 commits into from
Jul 19, 2024

Conversation

lucasbordeau
Copy link
Contributor

  • Removed enabled props from useScopedHotkeys becayse it doesn't work
  • Moved enter useScopedHotkeys in a handler that we drill down to the text inputs on the settings form

charlesBochet
charlesBochet approved these changes Jul 19, 2024
View reviewed changes
Copy link
Member

@charlesBochet charlesBochet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@charlesBochet charlesBochet merged commit b64e809 into main Jul 19, 2024
9 of 10 checks passed
@charlesBochet charlesBochet deleted the fix/text-input-shortcut-conflict branch July 19, 2024 17:25
This was referenced Jul 25, 2024
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charlesBochet charlesBochet charlesBochet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lucasbordeau @charlesBochet