Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test revert crm integration #6321

Merged
merged 5 commits into from
Jul 25, 2024
Merged

Test revert crm integration #6321

merged 5 commits into from
Jul 25, 2024

Conversation

martmull
Copy link
Contributor

PR to test revert integration in production

@martmull martmull marked this pull request as ready for review July 18, 2024 12:55
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

  • Added CRM migration feature in settings (packages/twenty-front/src/App.tsx)
  • Created new SettingsCRMMigration component (packages/twenty-front/src/pages/settings/crm-migration/SettingsCRMMigration.tsx)
  • Integrated Revert for CRM data synchronization (packages/twenty-server/package.json)
  • Added CRM Migration to settings navigation (packages/twenty-front/src/modules/settings/components/SettingsNavigationDrawerItems.tsx)
  • Introduced 'CRMMigration' enum in SettingsPath (packages/twenty-front/src/modules/types/SettingsPath.ts)

5 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings

@martmull martmull reopened this Jul 25, 2024
@@ -18,6 +18,7 @@ export enum SettingsPath {
NewObject = 'objects/new',
WorkspaceMembersPage = 'workspace-members',
Workspace = 'workspace',
CRMMigration = 'crm-migration',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not needed for merge but in future iterations I think we should rename it into something more generic like "import data" and also advert the CSV import in that tab because many people don't find it and it would be a good entry point to have it in settings

@FelixMalfait FelixMalfait merged commit b9c8d60 into main Jul 25, 2024
7 of 20 checks passed
@FelixMalfait FelixMalfait deleted the test-revert-crm-integration branch July 25, 2024 07:38
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

(updates since last review)

This pull request focuses on reverting the CRM integration and updating various dependencies and configurations across the codebase.

  • Removed .yarn/releases/yarn-4.0.2.cjs and added .yarn/releases/yarn-4.3.1.cjs: Updated Yarn version from 4.0.2 to 4.3.1.
  • Updated package.json: Added new dependencies (@aws-sdk/client-lambda, archiver, aws-sdk, fs-extra) and upgraded existing ones (@blocknote to 0.15.3, typescript to 5.3.3).
  • Modified packages/twenty-docker/twenty/entrypoint.sh: Added NODE_OPTIONS to increase max old space size for Node.js to 1500 MB.
  • Updated packages/twenty-front/src/effect-components/PageChangeEffect.tsx: Added CAPTCHA token request for Reset Password page.
  • Introduced new GraphQL types and mutations: Added support for serverless functions and AI SQL queries in packages/twenty-front/src/generated-metadata/graphql.ts.

These changes should be thoroughly tested to ensure compatibility and stability across the codebase.

300 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants