-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Set preselect field type on new field of object page #6314
feat: Set preselect field type on new field of object page #6314
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
No major changes found since last review.
No file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To complete this issue, we should have a way to know that we're creating a select field because we want to create board view, and then go back directly to the board view when we click on "Save" in the field creation form, and not to the settings field list, as it would be the case normally.
Thank you for your feedback
It makes sense. By the way, could we implement react router history to address this? |
Let's use |
5f1f2d1
to
d69d345
Compare
Hey sorry for the very long delay. I removed "navigateBack" not because it wasn't properly implemented but because we're careful not to bloat the API with edges cases and this implem seemed to specific to our use-case and not worth the complexity it adds in code. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for your contribution! Sorry for the long delay to review!
Thanks @Us3r-gitHub for your contribution! |
#5661