Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes data importer showing incorrect unmatched fields (# 6138) #6311

Merged
merged 2 commits into from
Jul 22, 2024
Merged

Fixes data importer showing incorrect unmatched fields (# 6138) #6311

merged 2 commits into from
Jul 22, 2024

Conversation

Faisal-imtiyaz123
Copy link
Contributor

fixes #6138

greptile-apps[bot]
greptile-apps bot reviewed Jul 17, 2024
View reviewed changes
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

  • Fixed unmatched fields count by filtering matchedOptions with undefined values in packages/twenty-front/src/modules/spreadsheet-import/steps/components/MatchColumnsStep/components/TemplateColumn.tsx
  • Improved accuracy of the data importer

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings

@thomtrp thomtrp self-assigned this Jul 22, 2024
@thomtrp thomtrp force-pushed the 6138_DataImporter-incorret-unmactedFields branch from 5e721f4 to a742614 Compare July 22, 2024 11:57
thomtrp
thomtrp approved these changes Jul 22, 2024
View reviewed changes
Copy link
Contributor

@thomtrp thomtrp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing @Faisal-imtiyaz123 ! 🔥

@thomtrp thomtrp merged commit 4f249df into twentyhq:main Jul 22, 2024
11 checks passed
@github-actions GitHub Actions
Copy link

Thanks @Faisal-imtiyaz123 for your contribution!
This marks your 0th PR on the repo. You're top 0% of all our contributors 🎉
See contributor page - Share on LinkedIn - Share on Twitter

Contributions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greptile-apps greptile-apps[bot] greptile-apps[bot] left review comments

@thomtrp thomtrp thomtrp approved these changes

Assignees

@thomtrp thomtrp

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Data Importer Shows Incorrect Unmatched Fields Count
2 participants
@Faisal-imtiyaz123 @thomtrp