Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rating filter/sort + fix isEmpty/isNotEmpty + fix combinedViewFilters #6310

Merged
merged 1 commit into from
Jul 17, 2024

Conversation

Weiko
Copy link
Member

@Weiko Weiko commented Jul 17, 2024

Context

  • Adding RATING sort and filter capabilities.
  • Fixing isEmpty/isNotEmpty filters
  • Fixing combined view filters so it combines filters per field metadata and not per filter id. This is more a product question but to me it does not make sense to apply multiples filters on the same field IF the operations is wrapped in a AND. If at some point we want to put a OR instead then that would make more sense

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

  • Added support for 'RATING' filter and sort capabilities (formatFieldMetadataItemsAsFilterDefinitions.ts, formatFieldMetadataItemsAsSortDefinitions.ts, FilterType.ts, getOperandsForFilterType.ts, isRecordMatchingFilter.ts, turnObjectDropdownFilterIntoQueryFilter.ts)
  • Introduced ObjectFilterDropdownRatingInput.tsx component for rating filter input
  • Fixed handling of isEmpty and isNotEmpty operands (MultipleFiltersDropdownContent.tsx, EditableFilterDropdownButton.tsx)
  • Updated combined view filters logic to use fieldMetadataId instead of id (useCombinedViewFilters.ts, useSaveCurrentViewFiltersAndSorts.ts, combinedViewFilters.ts)

12 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings

@charlesBochet charlesBochet merged commit efd932e into main Jul 17, 2024
11 of 13 checks passed
@charlesBochet charlesBochet deleted the c--add-rating-filter-sort-and-fix-is-empty branch July 17, 2024 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants