-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix tests and lint #6303
Fix tests and lint #6303
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
- Removed
setIsLoadedRecords
function fromuseState
hook inpackages/twenty-front/src/modules/object-record/record-show/hooks/useRecordShowPagePagination.ts
- Simplified state management for
isLoadedRecords
variable
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
(updates since last review)
- Enabled logging in Jest configuration (
packages/twenty-front/jest.config.ts
) - Updated GraphQL query variables for pagination in tests (
packages/twenty-front/src/modules/activities/hooks/__tests__/useActivityTargetsForTargetableObject.test.tsx
) - Replaced
Person
andCompany
types withObjectRecord
in mock data (packages/twenty-front/src/testing/mock-data/activities.ts
)
No major changes found since last review.
3 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
(updates since last review)
- Changed
silent
option totrue
in Jest configuration to suppress test output (packages/twenty-front/jest.config.ts
)
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
(updates since last review)
- Added
hasPreviousPage
topageInfo
inuseActivities.test.tsx
for pagination testing (packages/twenty-front/src/modules/activities/hooks/__tests__/useActivities.test.tsx
) - Included
hasPreviousPage
inuseFetchAllRecordIds.ts
for GraphQL pagination logic (packages/twenty-front/src/modules/object-record/hooks/__mocks__/useFetchAllRecordIds.ts
) - Updated
useFindManyRecordsQuery.test.tsx
to check forhasPreviousPage
in GraphQL query (packages/twenty-front/src/modules/object-record/hooks/__tests__/useFindManyRecordsQuery.test.tsx
)
3 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
(updates since last review)
- Adjusted global coverage thresholds for statements and lines in
packages/twenty-front/jest.config.ts
- Enhanced Storybook stories with detailed mock data in
packages/twenty-front/src/modules/activities/tasks/__stories__/TaskList.stories.tsx
- Added
__typename
field toActivityTarget
properties inpackages/twenty-front/src/modules/activities/types/ActivityTarget.ts
- Simplified mock data structure by removing type definitions in
packages/twenty-front/src/testing/mock-data/activities.ts
4 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
(updates since last review)
- Reordered imports and added
SnackBarProviderScope
inpackages/twenty-front/src/modules/activities/hooks/__tests__/useCreateActivityInDB.test.tsx
- Updated mocked data structure for tasks and activities in
packages/twenty-front/src/testing/mock-data/activities.ts
for type safety
2 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
@@ -71,6 +71,7 @@ const mocks: MockedResponse[] = [ | |||
} | |||
pageInfo { | |||
hasNextPage | |||
hasPreviousPage |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
Fixing tests and lint on main!