5899 display a banner to alert users which need to reconnect their account #6301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eed-to-reconnect-their-account
…eed-to-reconnect-their-account
…eed-to-reconnect-their-account
…eed-to-reconnect-their-account
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
- Added
userVarsfield toCurrentUsertype in/packages/twenty-front/src/modules/auth/states/currentUserState.ts - Introduced
InformationBannercomponent in/packages/twenty-front/src/modules/object-record/information-banner/InformationBanner.tsx - Integrated
InformationBannerinto multiple settings pages, including/packages/twenty-front/src/pages/settings/SettingsAppearance.tsx,/packages/twenty-front/src/pages/settings/SettingsBilling.tsx, and others - Updated
USER_QUERY_FRAGMENTto includeuserVarsin/packages/twenty-front/src/modules/users/graphql/fragments/userQueryFragment.ts - Removed unused import in
/packages/twenty-front/src/modules/users/components/UserProviderEffect.tsx
29 file(s) reviewed, 2 comment(s)
Edit PR Review Bot Settings
|
|
||
| const userVars = currentUser?.userVars; | ||
|
|
||
| const accountsToReconnect = userVars?.['ACCOUNTS_TO_RECONNECT'] ?? []; |
There was a problem hiding this comment.
Style: Consider adding a type check for userVars to ensure it is an object.
|
|
||
| return ( | ||
| <Banner> | ||
| Sync lost with mailbox {accountsToReconnect[0]}. Please reconnect for |
There was a problem hiding this comment.
Logic: Ensure accountsToReconnect[0] is defined before accessing it to avoid potential runtime errors.
There was a problem hiding this comment.
PR Summary
(updates since last review)
- Updated
fieldMetadataItemSchema.tsto acceptexistingLabelsfor dynamic validation - Enhanced
metadataLabelSchema.tsfor label uniqueness and improved error messages - Modified
SettingsDataModelFieldAboutForm.tsxfor better error handling and validation - Added error handling in
TextInputV2.tsxand updated styling for error states - Updated database commands in
0-22-upgrade-version.command.tsfor new address field and enum updates
27 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
…insufficient permissions
…eed-to-reconnect-their-account
…eed-to-reconnect-their-account
…eed-to-reconnect-their-account
…eed-to-reconnect-their-account
…eed-to-reconnect-their-account
packages/twenty-front/src/modules/object-record/information-banner/InformationBanner.tsx
Outdated
Show resolved
Hide resolved
packages/twenty-front/src/modules/object-record/information-banner/InformationBanner.tsx
Outdated
Show resolved
Hide resolved
packages/twenty-front/src/modules/object-record/information-banner/InformationBanner.tsx
Outdated
Show resolved
Hide resolved
packages/twenty-front/src/modules/object-record/information-banner/InformationBanner.tsx
Outdated
Show resolved
Hide resolved
| @@ -0,0 +1,136 @@ | |||
| import { formatUserVars } from 'src/engine/core-modules/user/utils/format-user-vars.util'; | |||
|
|
|||
| describe('formatUserVars', () => { | |||
packages/twenty-server/src/engine/core-modules/user/utils/format-user-vars.util.ts
Outdated
Show resolved
Hide resolved
packages/twenty-server/src/engine/core-modules/user/utils/format-user-vars.util.ts
Outdated
Show resolved
Hide resolved
|
|
||
| accountsToReconnect.push(connectedAccountId); | ||
|
|
||
| await this.keyValuePairService.set({ |
There was a problem hiding this comment.
we should use the userVar service!
There was a problem hiding this comment.
so we don't have to pass the 'type' (here you are relying on userVar to be the defaultValue which does not seem to be right!)
| await this.addToAccountsToReconnect(messageChannelId, workspaceId); | ||
| } | ||
|
|
||
| private async addToAccountsToReconnect( |
There was a problem hiding this comment.
looks like to be duplicated logic. I would put it in a connectedAccount service (we need to double check the dependencies) that would take { workspaceId, connectedAccountId } as parameters
…eed-to-reconnect-their-account
charlesBochet
approved these changes
Jul 27, 2024
There was a problem hiding this comment.
LGTM, I've push a few modifications:
- keep KeyValuePair service as simple and agnostic as possible
- enforce usage of userVarsService (no direct access to KeyValuePair service)
- add allowList on userVars resolver
- move userVars from user entity to a resolve field in user.resolver
- rework typings
|
|
||
| const userVars = currentUser?.userVars; | ||
|
|
||
| const accountIdToReconnect = |
There was a problem hiding this comment.
firstAccountIdToReconnect
charlesBochet
deleted the
5899-display-a-banner-to-alert-users-which-need-to-reconnect-their-account
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5899