fix: adding https in checkurltype #6295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
- Modified
/packages/twenty-front/src/utils/checkUrlType.ts - Added check to prepend "https://" if URL lacks protocol
- Ensures proper handling of LinkedIn and Twitter links
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
This reverts commit 4524913.
|
Never blindly follow AI 😜 |
There was a problem hiding this comment.
PR Summary
(updates since last review)
- Updated
/packages/twenty-front/src/modules/ui/field/display/components/LinkDisplay.tsxto prepend 'https://' to URLs missing a protocol - Removed protocol prepending logic from
/packages/twenty-front/src/utils/checkUrlType.ts - Ensured consistent URL handling across components
- Watch for any unintended side effects in URL formatting
2 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
FelixMalfait
approved these changes
Jul 16, 2024
| @@ -18,6 +18,12 @@ export const LinkDisplay = ({ value }: LinkDisplayProps) => { | |||
| return <></>; | |||
| } | |||
|
|
|||
| const absoluteUrl = url | |||
There was a problem hiding this comment.
we should leverage existing utils here :)
There was a problem hiding this comment.
Yes good point, might as well change it here too then,
https://github.com/twentyhq/twenty/blob/main/packages/twenty-front/src/modules/ui/field/display/components/URLDisplay.tsx#L32
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix URL handling for LinkedIn and Twitter links
Fixes #6287
Solution
Updated
checkUrlTypefunction to prepend "https://" to URLs if missing, ensuring proper handling of social media links.Changes
/packages/twenty-front/src/utils/checkUrlType.ts