Create command to migrate message channel sync stage enum

[bosiraphael]

Create command to migrate message channel sync stage enum

[greptile-apps]

PR Summary

• Added 0-22-update-message-channel-sync-stage-enum.command.ts to migrate syncStage enum for messageChannel (packages/twenty-server/src/database/commands/0-22-update-message-channel-sync-stage-enum.command.ts)
• Updated database-command.module.ts to include UpdateMessageChannelSyncStageEnumCommand (packages/twenty-server/src/database/commands/database-command.module.ts)

_{2 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings}

[greptile-apps]

PR Summary

(updates since last review)

• Removed FieldMetadataType.PROBABILITY from simple field types in mapFieldMetadataToGraphqlQuery function (packages/twenty-server/src/engine/api/rest/core/query-builder/utils/map-field-metadata-to-graphql-query.utils.ts)
• Removed handling of PROBABILITY field type in computeInputFields and getTypeFromFieldMetadataType functions (packages/twenty-zapier/src/utils/computeInputFields.ts)
• Removed PROBABILITY enum value from FieldMetadataType enum (packages/twenty-zapier/src/utils/data.types.ts)

_{3 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings}

[ijreilly]

Why not only run it active workspaces like we do now, for sync-metadata and other recent commands?
otherwise it will run on +8k workspaces which may take long + will fail on numerous workspaces

[ijreilly]

so if it fails for any workspace, the command will stop altogether. Don't we want to continue to the next workspace instead? it's what we do elsewhere

[ijreilly]

@bosiraphael
https://github.com/twentyhq/twenty/blob/main/packages/twenty-server/src/engine/workspace-manager/workspace-sync-metadata/commands/sync-workspace-metadata.command.ts
What I find interesting

• loops on active workspaces only (you can reuse the same util)
• try / catch block for each workspace, to log the error then continue

[greptile-apps]

PR Summary

(updates since last review)

• Updated message channel sync stage enum
• Replaced workspace repository with workspace status service for fetching active workspace IDs (packages/twenty-server/src/database/commands/0-22-update-message-channel-sync-stage-enum.command.ts)

No major changes found since last review.

_{1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings}

[greptile-apps]

PR Summary

(updates since last review)

• Added error handling for data source metadata retrieval
• Enhanced logging for migration process errors
• Ensured transaction rollback on failure
• Updated syncStage field metadata with new options
• Incremented workspace cache version

File: packages/twenty-server/src/database/commands/0-22-update-message-channel-sync-stage-enum.command.ts

_{1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings}

[charlesBochet]

Approved!