Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Remove usage of deprecated FieldMetadata type probability #6279

Merged
merged 2 commits into from
Jul 16, 2024

Conversation

ijreilly
Copy link
Collaborator

Bad timing between merge of 364caf0 and c0f6f52 a few minutes apart caused issues. Fixing it here !

Copy link
Contributor

@bosiraphael bosiraphael left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

  • Removed deprecated FieldMetadataType.PROBABILITY from mapFieldMetadataToGraphqlQuery in /packages/twenty-server/src/engine/api/rest/core/query-builder/utils/map-field-metadata-to-graphql-query.utils.ts
  • Updated getTypeFromFieldMetadataType to exclude FieldMetadataType.PROBABILITY in /packages/twenty-zapier/src/utils/computeInputFields.ts
  • Adjusted input field computation logic to remove FieldMetadataType.PROBABILITY in /packages/twenty-zapier/src/utils/computeInputFields.ts

2 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

(updates since last review)

  • Removed deprecated FieldMetadataType.PROBABILITY from /packages/twenty-zapier/src/utils/data.types.ts
  • Ensure no usage of PROBABILITY type in the Zapier integration

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings

@bosiraphael bosiraphael merged commit 26bffce into main Jul 16, 2024
5 of 6 checks passed
@bosiraphael bosiraphael deleted the fix-issue-probability branch July 16, 2024 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants