Fixed mass deletion page size. #6275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
- Fixed page size inconsistency in
packages/twenty-front/src/modules/object-record/hooks/useFetchAllRecordIds.ts - Introduced
limitvariable infetchMorefunction - Updated logic to handle
lastCursorcorrectly
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
There was a problem hiding this comment.
PR Summary
(updates since last review)
- Introduced dynamic page size for batch deletions in
packages/twenty-front/src/modules/object-record/hooks/useDeleteManyRecords.ts - Fetched page size from
apiConfigStatefor consistency - Ensured alignment between page size calculation and deletion process
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
thomtrp
approved these changes
Jul 16, 2024
There was a problem hiding this comment.
PR Summary
(updates since last review)
- Set
limittomockPageSizeinpackages/twenty-front/src/modules/object-record/hooks/__mocks__/useFetchAllRecordIds.ts - Added
limitparameter to query inpackages/twenty-front/src/modules/object-record/hooks/useFetchAllRecordIds.ts
2 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
ijreilly
approved these changes
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed when page size was not the same as the one used for calculating number of pages