fix: conditionally rendered Tablist only if there are multiple accounts.

[adithej]

issue - 6267

[greptile-apps]

PR Summary

• Conditionally render TabList in SettingsAccountsCalendarChannelsContainer.tsx if multiple calendar channels exist (packages/twenty-front/src/modules/settings/accounts/components/SettingsAccountsCalendarChannelsContainer.tsx).
• Conditionally render TabList in SettingsAccountsMessageChannelsContainer.tsx if multiple accounts exist (packages/twenty-front/src/modules/settings/accounts/components/SettingsAccountsMessageChannelsContainer.tsx).

_{2 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings}

[charlesBochet]

Hi @adithej, thanks for your contribution! The code looks good but we have a padding issue, see comment on another (duplicated) PR here: #6277

[greptile-apps]

PR Summary

(updates since last review)

• Added CalendarEventDetailsEffect component to handle upsertion of calendar event records (packages/twenty-front/src/modules/activities/calendar/components/CalendarEventDetailsEffect.tsx)
• Included CalendarEventDetailsEffect and RecordValueSetterEffect in RightDrawerCalendarEvent.tsx (packages/twenty-front/src/modules/activities/calendar/right-drawer/components/RightDrawerCalendarEvent.tsx)
• Removed exclusion of 'probability' fields in filter definitions (packages/twenty-front/src/modules/object-metadata/utils/formatFieldMetadataItemsAsFilterDefinitions.ts)
• Introduced Recoil state for dynamic mutation page size in useDeleteManyRecords (packages/twenty-front/src/modules/object-record/hooks/useDeleteManyRecords.ts)
• Removed FieldMetadataType.PROBABILITY from various files, impacting field handling and validation (packages/twenty-server/src/engine/metadata-modules/field-metadata/field-metadata.entity.ts, packages/twenty-server/src/engine/metadata-modules/field-metadata/utils/validate-default-value-for-type.util.ts)

_{37 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings}

[greptile-apps]

PR Summary

(updates since last review)

• Conditionally render TabList in SettingsAccountsCalendarChannelsContainer.tsx if multiple calendar channels (/packages/twenty-front/src/modules/settings/accounts/components/SettingsAccountsCalendarChannelsContainer.tsx)
• Conditionally render TabList in SettingsAccountsMessageChannelsContainer.tsx if multiple accounts (/packages/twenty-front/src/modules/settings/accounts/components/SettingsAccountsMessageChannelsContainer.tsx)
• Remove padding-top from StyledDetailsContainer in SettingsAccountsCalendarChannelDetails.tsx (/packages/twenty-front/src/modules/settings/accounts/components/SettingsAccountsCalendarChannelDetails.tsx)
• Remove padding-top from StyledDetailsContainer in SettingsAccountsMessageChannelDetails.tsx (/packages/twenty-front/src/modules/settings/accounts/components/SettingsAccountsMessageChannelDetails.tsx)
• Introduce StyledMessageContainer for bottom padding in SettingsAccountsMessageChannelsContainer.tsx (/packages/twenty-front/src/modules/settings/accounts/components/SettingsAccountsMessageChannelsContainer.tsx)

_{4 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings}

[adithej]

Hi @charlesBochet, I noticed the conversation regarding the padding issue. I have rectified it , let me know it need any more changes

[charlesBochet]

LGTM!

[greptile-apps]

PR Summary

(updates since last review)

• Conditionally render TabList in SettingsAccountsCalendarChannelsContainer.tsx if multiple calendar channels (/packages/twenty-front/src/modules/settings/accounts/components/SettingsAccountsCalendarChannelsContainer.tsx)
• Conditionally render TabList in SettingsAccountsMessageChannelsContainer.tsx if multiple accounts (/packages/twenty-front/src/modules/settings/accounts/components/SettingsAccountsMessageChannelsContainer.tsx)

_{2 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings}

[github-actions]

Thanks @adithej for your contribution!
This marks your 0th PR on the repo. You're top 0% of all our contributors 🎉
See contributor page - Share on LinkedIn - Share on Twitter