Add interceptors for auto-resolvers #6270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomtrp
force-pushed
the
tt-add-interceptors-for-auto-resolvers
branch
from
89909ac to
aa7e6ae
Compare
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
- Added
FieldMetadataGraphqlApiExceptionInterceptorin/packages/twenty-server/src/engine/metadata-modules/field-metadata/field-metadata.module.ts - Introduced
/packages/twenty-server/src/engine/metadata-modules/field-metadata/interceptors/field-metadata-graphql-api-exception.interceptor.ts - Added
ObjectMetadataGraphqlApiExceptionInterceptorin/packages/twenty-server/src/engine/metadata-modules/object-metadata/object-metadata.module.ts - Introduced
/packages/twenty-server/src/engine/metadata-modules/object-metadata/interceptors/object-metadata-graphql-api-exception.interceptor.ts - Added
RelationMetadataGraphqlApiExceptionInterceptorin/packages/twenty-server/src/engine/metadata-modules/relation-metadata/relation-metadata.module.ts - Introduced
/packages/twenty-server/src/engine/metadata-modules/relation-metadata/interceptors/relation-metadata-graphql-api-exception.interceptor.ts
6 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
There was a problem hiding this comment.
PR Summary
(updates since last review)
- Added
FieldMetadataGraphqlApiExceptionInterceptorin/packages/twenty-server/src/engine/metadata-modules/field-metadata/field-metadata.module.ts - Introduced
/packages/twenty-server/src/engine/metadata-modules/field-metadata/interceptors/field-metadata-graphql-api-exception.interceptor.ts - Added
ObjectMetadataGraphqlApiExceptionInterceptorin/packages/twenty-server/src/engine/metadata-modules/object-metadata/object-metadata.module.ts - Introduced
/packages/twenty-server/src/engine/metadata-modules/object-metadata/interceptors/object-metadata-graphql-api-exception.interceptor.ts - Added
RelationMetadataGraphqlApiExceptionInterceptorin/packages/twenty-server/src/engine/metadata-modules/relation-metadata/relation-metadata.module.ts
6 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
Weiko
approved these changes
Jul 15, 2024
|
@Weiko not sure I will keep this or not. But I spent 2 hours yesterday to make it work with auto-resolvers and I could not. So I prefer work on it once we deprecate nestjs query |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Services exceptions are not catch when the endpoint comes from an auto-resolver.
We want to remove auto-resolver but it requires to implement pagination by ourselves.
As a quick fix, here are interceptors that will trigger the exception handler.
I had a hard time making it generic so I finally added one interceptor for each since this is not supposed to stay