6254 double creation of contacts when updating calendar event participants #6269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
- Removed
iCalUIDfrom participants mapping informat-google-calendar-event.util.ts - Removed
workspaceIdparameter fromupsertAndDeleteCalendarEventParticipantsincalendar-save-events.service.ts - Refactored
calendar-event-participant.service.tsto optimize participant update and delete operations - Removed
iCalUIDproperty fromCalendarEventParticipanttype incalendar-event.ts
4 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
There was a problem hiding this comment.
PR Summary
(updates since last review)
- Updated import statement for 'lodash.differencewith'
- Modified logic for upserting and deleting calendar event participants
- Adjusted service methods to handle participant matching/unmatching by email, person ID, and workspace member ID
File: packages/twenty-server/src/modules/calendar/calendar-event-participant-manager/services/calendar-event-participant.service.ts
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
There was a problem hiding this comment.
@bosiraphael Don't know why but it's calendar events are not created while testing in local on this branch
|
Re-tried and it worked but now the RightDrawer is empty: |
|
|
Nevermind, I have reset and restarted everything and it works! |
charlesBochet
deleted the
6254-double-creation-of-contacts-when-updating-calendar-event-participants
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6254