Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug return multi select fields in rest api response #6253

Merged
merged 2 commits into from
Jul 16, 2024
Merged

Bug return multi select fields in rest api response #6253

merged 2 commits into from
Jul 16, 2024

Conversation

martmull
Copy link
Contributor

@martmull martmull commented Jul 15, 2024 •
edited
Loading

@martmull martmull marked this pull request as ready for review July 15, 2024 08:22
greptile-apps[bot]
greptile-apps bot reviewed Jul 15, 2024
View reviewed changes
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

  • Updated mapFieldMetadataToGraphqlQuery to handle FieldMetadataType.MULTI_SELECT and FieldMetadataType.RAW_JSON
  • Modified function calls in map-field-metadata-to-graphql-query.utils.spec.ts to pass an array of object metadata items
  • Added new tests for all field metadata types in map-field-metadata-to-graphql-query.utils.spec.ts
  • Ensure multi-select fields are correctly returned in REST API response

2 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings

FelixMalfait
FelixMalfait approved these changes Jul 16, 2024
View reviewed changes
Copy link
Member

@FelixMalfait FelixMalfait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great

@FelixMalfait FelixMalfait merged commit c0f6f52 into main Jul 16, 2024
6 checks passed
@FelixMalfait FelixMalfait deleted the bug-return-multi-select-fields-in-rest-api-response branch July 16, 2024 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greptile-apps greptile-apps[bot] greptile-apps[bot] left review comments

@FelixMalfait FelixMalfait FelixMalfait approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@martmull @FelixMalfait