Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix performance tests #6245

Merged
merged 4 commits into from
Jul 13, 2024
Merged

Fix performance tests #6245

merged 4 commits into from
Jul 13, 2024

Conversation

charlesBochet
Copy link
Member

No description provided.

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

  • Adjusted performance testing parameters in packages/twenty-front/src/modules/object-record/record-field/meta-types/display/components/__stories__/perf/AddressFieldDisplay.perf.stories.tsx
  • Reduced number of runs from 30 to 20
  • Increased number of tests per run from 50 to 100
  • Aimed to optimize performance testing process
  • Potentially provides more robust data per run while reducing total runs

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

(updates since last review)

  • Replaced dynamic address content with static string 'toto' in packages/twenty-front/src/modules/object-record/record-field/meta-types/display/components/AddressFieldDisplay.tsx
  • Temporary measure for testing purposes
  • Removes functionality of displaying actual address data

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

(updates since last review)

  • Reduced maxWorkers for storybook:test:no-coverage target from 3 to 2 in nx.json
  • Updated AddressFieldDisplay component to use useAddressFieldDisplay hook for dynamic address fetching
  • Improved address display by filtering out empty fields and joining non-empty fields with a comma separator in AddressFieldDisplay component

2 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

(updates since last review)

  • Updated userEvent.click calls to use await canvas.findByText for asynchronous element finding in packages/twenty-front/src/pages/settings/developers/__stories__/api-keys/SettingsDevelopersApiKeysDetail.stories.tsx
  • Improved test stability by ensuring elements are found before interaction

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings

@charlesBochet charlesBochet merged commit e5d76a3 into main Jul 13, 2024
10 checks passed
@charlesBochet charlesBochet deleted the fix-tests-v5 branch July 13, 2024 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant