Fix custom errors thrown as 500 #6238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
- Updated
packages/twenty-server/src/engine/utils/global-exception-handler.util.tsto handleBaseGraphQLErrordirectly. - Prevented fallback to HTTP 500 for custom GraphQL errors.
- Ensured custom GraphQL errors return intended status codes.
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
There was a problem hiding this comment.
PR Summary
(updates since last review)
- Excluded 'Link' field type in
StyledSettingsObjectFieldTypeSelectin/packages/twenty-front/src/pages/settings/data-model/SettingsObjectFieldEdit.tsx - Uncommented 'Link' field type in exclusion list in
/packages/twenty-front/src/pages/settings/data-model/SettingsObjectNewField/SettingsObjectNewFieldStep2.tsx - Added validation to deprecate 'LINK' field types in
/packages/twenty-server/src/engine/metadata-modules/field-metadata/field-metadata.service.ts - Reordered imports for better organization in
/packages/twenty-server/src/engine/metadata-modules/field-metadata/field-metadata.service.ts
3 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
ijreilly
approved these changes
Jul 12, 2024
charlesBochet
approved these changes
Jul 12, 2024
There was a problem hiding this comment.
PR Summary
(updates since last review)
- Replaced
useExceptionHandlerwithuseGraphQLErrorHandlerHookin/packages/twenty-server/src/engine/api/graphql/metadata.module-factory.ts - Introduced
EngineGraphQLModulein/packages/twenty-server/src/engine/core-modules/graphql/engine-graphql.module.ts - Added
useGraphQLErrorHandlerHookin/packages/twenty-server/src/engine/core-modules/graphql/hooks/use-graphql-error-handler.hook.ts - Added
generateGraphQLErrorFromErrorutility in/packages/twenty-server/src/engine/core-modules/graphql/utils/generate-graphql-error-from-error.util.ts - Updated exception handling logic across multiple files to prevent custom GraphQL errors from defaulting to 500 errors
16 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings
| graphqlError.extensions['response'] = error.message; | ||
| } | ||
|
|
||
| return error; |
There was a problem hiding this comment.
🧠 logic: Should return graphqlError instead of error to ensure the converted error is returned.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We call convertExceptionToGraphQLError in the exception handler for http exceptions but we don't take into account those that already are graphqlErrors and because of that the logic of convertExceptionToGraphql is to fallback to a 500.
Now if the exception is a BaseGraphqlError (custom graphql error we throw in the code), we throw them directly.
BEFORE
AFTER
