Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: settings object slug link #6228

Merged

Conversation

rostaklein
Copy link
Contributor

fixes #6213

fixed the mentioned case + tried to find&fix other possible broken links

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

  • Updated navigation link in /packages/twenty-front/src/modules/object-record/record-index/components/RecordIndexBoardDataLoaderEffect.tsx to use getObjectSlug
  • Fixed settings object link in /packages/twenty-front/src/modules/object-record/record-table/record-table-header/components/RecordTableHeaderPlusButtonContent.tsx using getObjectSlug
  • Corrected object slug link in /packages/twenty-front/src/modules/settings/data-model/graph-overview/components/SettingsDataModelOverviewObject.tsx with getObjectSlug
  • Ensured URL formation in /packages/twenty-front/src/modules/views/view-picker/hooks/useGetAvailableFieldsForKanban.ts using getObjectSlug

4 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings

Copy link
Member

@FelixMalfait FelixMalfait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

going above and beyond again :))

Thanks!!!

@FelixMalfait FelixMalfait merged commit 4350279 into twentyhq:main Jul 11, 2024
10 of 11 checks passed
Copy link

Thanks @rostaklein for your contribution!
This marks your 7th PR on the repo. You're top 3% of all our contributors 🎉
See contributor page - Share on LinkedIn - Share on Twitter

Contributions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Link to navigate to object settings is broken
2 participants