Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix address field in raw query #6226

Merged
merged 3 commits into from
Jul 11, 2024
Merged

Conversation

bosiraphael
Copy link
Contributor

The old address field has been deprecated but the raw query in company.repository hasn't been updated accordingly

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

  • Updated createCompany method in /packages/twenty-server/src/modules/company/repositories/company.repository.ts to use addressAddressCity field
  • Deprecated address field removed from raw SQL query

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings

@ijreilly
Copy link
Collaborator

ijreilly commented Jul 11, 2024

As we discussed with @bosiraphael, this will break email sync on workspaces that have not run sync-metadata

@ijreilly ijreilly merged commit faf462f into main Jul 11, 2024
6 checks passed
@ijreilly ijreilly deleted the fix-create-company-adress-field branch July 11, 2024 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants