Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed various bugs in activity creation #6208

Merged
merged 7 commits into from
Jul 10, 2024
Merged

Conversation

lucasbordeau
Copy link
Contributor

@lucasbordeau lucasbordeau commented Jul 10, 2024

  • Fixed activity creation in cache
  • Fixed activity creation in DB, where the relation target was disappearing after creation
  • Added an option to match root query filter in creation optimistic effect to avoid adding the newly created record in every mounted query in Apollo cache on the same object (which was causing notes to be duplicated on every object in the cache)
  • Fixed tab list scope id
  • Fixed various browser console warnings

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

  • Enhanced activity creation process in /packages/twenty-front/src/modules/activities/hooks/useCreateActivityInDB.ts
  • Deleted /packages/twenty-front/src/modules/activities/timeline/components/Timeline.tsx
  • Simplified /packages/twenty-front/src/modules/activities/timeline/components/TimelineCreateButtonGroup.tsx
  • Removed targetableObject prop in /packages/twenty-front/src/modules/activities/timelineActivities/components/TimelineActivities.tsx
  • Introduced root query filter matching in /packages/twenty-front/src/modules/apollo/optimistic-effect/utils/triggerCreateRecordsOptimisticEffect.ts

11 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings

@FelixMalfait FelixMalfait merged commit 6bc3663 into main Jul 10, 2024
12 of 13 checks passed
@FelixMalfait FelixMalfait deleted the fix/activity-creation branch July 10, 2024 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants