Deprecate Probability field on Opportunity #6207
Conversation
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
- Removed 'probability' field from GraphQL queries in
packages/twenty-front/src/modules/object-record/hooks/__mocks__/useFindManyRecords.tsandpackages/twenty-front/src/modules/search/hooks/__mocks__/useFilteredSearchEntityQuery.ts - Removed 'probability' field from mock data in
packages/twenty-front/src/modules/sign-in-background-mock/constants/SignInBackgroundMockCompanies.tsandpackages/twenty-front/src/testing/mock-data/view-fields.ts - Removed 'probability' field from seed data in
packages/twenty-server/src/database/typeorm-seeds/workspace/opportunities.ts - Removed 'probability' field from data generation in
packages/twenty-server/src/engine/workspace-manager/demo-objects-prefill-data/opportunity.ts - Deprecated 'probability' field in
packages/twenty-server/src/modules/opportunity/standard-objects/opportunity.workspace-entity.ts
9 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
| @@ -251,7 +251,7 @@ export const OPPORTUNITY_STANDARD_FIELD_IDS = { | |||
| name: '20202020-8609-4f65-a2d9-44009eb422b5', | |||
| amount: '20202020-583e-4642-8533-db761d5fa82f', | |||
| closeDate: '20202020-527e-44d6-b1ac-c4158d307b97', | |||
| probability: '20202020-69d4-45f3-9703-690b09fafcf0', | |||
| probability_deprecated: '20202020-69d4-45f3-9703-690b09fafcf0', | |||
There was a problem hiding this comment.
Should we use probabilityDeprecated instead to remain consistent?
There was a problem hiding this comment.
oops sure, thanks
There was a problem hiding this comment.
I saw Address_old was this way also (and did a quick PR fix for database:reset, make sure this PR doesn't break it also), maybe still time to fix it for Address
There was a problem hiding this comment.
oops yes still time thanks for catching this
| type: FieldMetadataType.TEXT, | ||
| label: 'Probability', | ||
| description: 'Opportunity probability', | ||
| icon: 'IconProgressCheck', | ||
| defaultValue: "'0'", | ||
| }) | ||
| @WorkspaceIsDeprecated() |
There was a problem hiding this comment.
Could we move all deprecated fields at the bottom of files by convention?
| type: FieldMetadataType.TEXT, | ||
| label: 'Probability', | ||
| description: 'Opportunity probability', | ||
| icon: 'IconProgressCheck', | ||
| defaultValue: "'0'", | ||
| }) | ||
| @WorkspaceIsDeprecated() | ||
| probability: string; |
There was a problem hiding this comment.
should this also be renamed to probabilityDeprecated? (if we want to introduce a new probability field soon?)
There was a problem hiding this comment.
Im not sure - I don't think we have planned to introduce a new probability field for now, so the vision is to consider this field custom, not to discourage its usage for now. its what I had shared in the doc (doc is still to be completed though and migrated to github). but open to rediscuss this
There was a problem hiding this comment.
PR Summary
(updates since last review)
- Renamed
probability_deprecatedtoprobabilityDeprecatedinpackages/twenty-server/src/engine/workspace-manager/workspace-sync-metadata/constants/standard-field-ids.ts - Re-added deprecated
address_oldfield inpackages/twenty-server/src/modules/company/standard-objects/company.workspace-entity.ts - Deprecated
probabilityfield inpackages/twenty-server/src/modules/opportunity/standard-objects/opportunity.workspace-entity.tsusing@WorkspaceIsDeprecated()decorator
3 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
There was a problem hiding this comment.
PR Summary
(updates since last review)
- Removed
Timeline.tsxcomponent, indicating potential deprecation or relocation of timeline functionality (packages/twenty-front/src/modules/activities/timeline/components/Timeline.tsx) - Added
shouldMatchRootQueryFilterparameter to control cache updates intriggerCreateRecordsOptimisticEffect,useCreateManyRecords, anduseCreateOneRecordhooks (packages/twenty-front/src/modules/apollo/optimistic-effect/utils/triggerCreateRecordsOptimisticEffect.ts,packages/twenty-front/src/modules/object-record/hooks/useCreateManyRecords.ts,packages/twenty-front/src/modules/object-record/hooks/useCreateOneRecord.ts) - Updated CSS height property from
100vhto100dvhfor better viewport handling across multiple components (packages/twenty-front/src/loading/components/LeftPanelSkeletonLoader.tsx,packages/twenty-front/src/loading/components/UserOrMetadataLoader.tsx, etc.) - Introduced new command to add a new address field to views with deprecated address fields (
packages/twenty-server/src/database/commands/0-22-add-new-address-field-to-views-with-deprecated-address.command.ts) - Simplified
TimelineCreateButtonGroupby removingopenCreateActivityfunction andtargetableObjectprop (packages/twenty-front/src/modules/activities/timeline/components/TimelineCreateButtonGroup.tsx)
28 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
Closes #5735.
The field probability on opportunity will -
This field is deprecated as a standard field but not replaced by another one, so we are not adding the
(deprecated)suffix in the label.