Update privacy policy links #6206
Conversation
bosiraphael
commented
Jul 10, 2024
bosiraphael
commented
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
- Updated import order and added styles for anchor tags in
packages/twenty-front/src/modules/auth/sign-in-up/components/FooterNote.tsx - Made privacy policy link in
packages/twenty-front/src/modules/auth/sign-in-up/components/SignInUpForm.tsxa clickable hyperlink that opens in a new tab - Updated privacy policy link in
packages/twenty-front/src/pages/auth/Invite.tsxto open in a new tab withnoopener noreferrerattributes
3 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
|
If we link the privacy policy we should also link the terms :) Btw we need to update the privacy policy, as we did introduce telemetry in the app which isn't reflected at all. We also enabled Cloudflare analytics which doesn't add a cookie but it still tracking some behavior (cf landing). So while our privacy policy remains much better than the norm, it isn't as friendly as it was. @Bonapara would you mind please updating the text of the Privacy Policy on Framer to reflect Telemetry+Cloudflare Analytics? I think we probably need to add a section "As a user" (subscriber being marketing channel only / email is collected but not using the app) - at the time we did the policy we didn't have a functional app. Thanks a lot! |
There was a problem hiding this comment.
PR Summary
(updates since last review)
- Modified
packages/twenty-front/src/modules/auth/sign-in-up/components/FooterNote.tsxto update text-decoration style for anchor tags. - Updated Terms of Service and Privacy Policy links in
packages/twenty-front/src/modules/auth/sign-in-up/components/SignInUpForm.tsx. - Ensured external links in
packages/twenty-front/src/pages/auth/Invite.tsxopen in a new tab.
3 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
