Add error handling service for calendar import #6203
Conversation
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
- Added
CalendarEventImportErrorHandlerServicetocalendar-event-import-manager.module.ts - Introduced
CALENDAR_THROTTLE_DURATIONandCALENDAR_THROTTLE_MAX_ATTEMPTSconstants - Removed
syncCursorupdate logic fromGoogleCalendarGetEventsService - Added
parseGoogleCalendarErrorutility function - Created
calendar-event-import-error-handling.service.tsfor structured error handling
8 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
There was a problem hiding this comment.
PR Summary
(updates since last review)
- Added
handleErrormethod ingoogle-calendar-get-events.service.tsfor robust error management - Introduced
GoogleCalendarErrortype ingoogle-calendar-error.type.tsfor standardized error objects - Added
parseGaxiosErrorutility inparse-gaxios-error.util.tsfor mapping Gaxios errors - Updated
parse-google-calendar-error.util.tsto useGoogleCalendarErrortype for better type safety
No major changes found since last review.
4 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
There was a problem hiding this comment.
PR Summary
(updates since last review)
- Removed
calendarChannelRepositorydependency ingoogle-calendar-get-events.service.ts - Added error handling logic in
getCalendarEventsmethod - Introduced utility function in
parse-google-calendar-error.util.tsfor parsing Google Calendar errors - Categorized errors into types like
INSUFFICIENT_PERMISSIONS,TEMPORARY_ERROR,NOT_FOUND, andUNKNOWN
2 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
There was a problem hiding this comment.
PR Summary
(updates since last review)
- Introduced
CalendarEventImportSyncStepenum for standardized sync steps - Modified error handling logic to use the new enum
- Added
handleNotFoundErrormethod for specific 'NOT_FOUND' error handling based on sync step
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
There was a problem hiding this comment.
PR Summary
(updates since last review)
- Enhanced error handling for calendar event import
- Utilized
CalendarEventImportErrorHandlerService - Differentiated between full and partial fetches using
CalendarEventImportSyncStepandCalendarChannelSyncStageenums
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
There was a problem hiding this comment.
PR Summary
(updates since last review)
- Updated error handling in
packages/twenty-server/src/modules/calendar/calendar-event-import-manager/services/calendar-events-import.service.ts - Replaced manual error creation with
CalendarEventImportErrorHandlerService - Simplified error handling process for better maintainability
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
…tialMessageListFetch
There was a problem hiding this comment.
PR Summary
(updates since last review)
- Added
markAsCompletedAndSchedulePartialMessageListFetchmethod inpackages/twenty-server/src/modules/calendar/calendar-event-import-manager/services/calendar-channel-sync-status.service.ts - Integrated
CalendarEventImportErrorHandlerServiceinpackages/twenty-server/src/modules/calendar/calendar-event-import-manager/services/calendar-events-import.service.ts - Replaced
schedulePartialCalendarEventListFetchwithmarkAsCompletedAndSchedulePartialMessageListFetchincalendar-events-import.service.ts - Reset throttle failure count and sync stage start time in
calendar-channel-sync-status.service.ts
2 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
There was a problem hiding this comment.
PR Summary
(updates since last review)
- Added Kubernetes and Terraform configurations for deploying TwentyCRM (
packages/twenty-docker/k8s/). - Enhanced error handling for link deletion in
LinksFieldInput.tsxandLinksFieldMenuItem.tsx. - Updated
absoluteUrlSchema.tsto allow empty strings as valid input. - Improved error handling in
0-22-update-boolean-fields-null-default-values-and-null-values.command.ts. - Removed
WorkspaceGatedecorator inconnected-account.workspace-entity.ts.
32 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
There was a problem hiding this comment.
PR Summary
(updates since last review)
- Updated cron pattern to run every minute (
packages/twenty-server/src/modules/calendar/calendar-event-import-manager/crons/commands/calendar-event-list-fetch.cron.command.ts) - Enhanced error handling logic for Google Calendar API responses (
packages/twenty-server/src/modules/calendar/calendar-event-import-manager/drivers/google-calendar/services/google-calendar-get-events.service.ts)
2 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
There was a problem hiding this comment.
PR Summary
(updates since last review)
- Updated cron pattern to run every five minutes (
packages/twenty-server/src/modules/calendar/calendar-event-import-manager/crons/commands/calendar-event-list-fetch.cron.command.ts)
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
| @@ -90,4 +77,34 @@ export class GoogleCalendarGetEventsService { | |||
| nextSyncCursor: nextSyncToken || '', | |||
| }; | |||
| } | |||
|
|
|||
| private handleError(error: GaxiosError) { | |||
There was a problem hiding this comment.
We can improve the naming here as handleError is actually a throwCalendarEventError
| ) { | ||
| throw parseGaxiosError(error); | ||
| } | ||
| if (error.response?.status !== 410) { |
There was a problem hiding this comment.
this if condition needs some details to be added. Why do we ignore 410? Also, it's preferrable to use a if (edgeCase) { return } pattern instead of if (!edgeCase) which leads to nested if / elses that are harder to read
| throw parseGaxiosError(error); | ||
| } | ||
| if (error.response?.status !== 410) { | ||
| const googleCalendarError: GoogleCalendarError = { |
There was a problem hiding this comment.
lastly, why do we do this construction here and not in parseGoogleCalendarError function?
There was a problem hiding this comment.
PR Summary
(updates since last review)
- Added error handling service for calendar imports (
packages/twenty-server/src/engine/core-modules/graphql/engine-graphql.module.ts,packages/twenty-server/src/engine/core-modules/graphql/hooks/use-graphql-error-handler.hook.ts) - Updated address fields to structured format across multiple modules (
packages/twenty-server/src/database/typeorm-seeds/workspace/companies.ts,packages/twenty-server/src/modules/company/standard-objects/company.workspace-entity.ts) - Removed
Timeline.tsxcomponent (packages/twenty-front/src/modules/activities/timeline/components/Timeline.tsx) - Introduced
isCancelDisabledprop toSaveAndCancelButtonscomponent (packages/twenty-front/src/pages/settings/data-model/SettingsObjectEdit.tsx) - Enhanced Recoil and Apollo Client integration for activity creation (
packages/twenty-front/src/modules/activities/hooks/useCreateActivityInDB.ts)
94 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
Add error handling service for calendar import