Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update boolean field command to skip workspace instead of throwing #6196

Merged
merged 1 commit into from
Jul 10, 2024
Merged

Update boolean field command to skip workspace instead of throwing #6196

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions ...de-version/0-22/0-22-update-boolean-fields-null-default-values-and-null-values.command.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,9 +76,10 @@ export class UpdateBooleanFieldsNullDefaultValuesAndNullValuesCommand extends Co
);

if (!dataSourceMetadata) {
throw new Error(
this.logger.log(
`Could not find dataSourceMetadata for workspace ${workspaceId}`,
);
continue;
}

const workspaceDataSource =
Expand Down Expand Up @@ -115,9 +116,10 @@ export class UpdateBooleanFieldsNullDefaultValuesAndNullValuesCommand extends Co

for (const booleanField of booleanFieldsWithoutDefaultValue) {
if (!booleanField.object) {
throw new Error(
this.logger.log(
`Could not find objectMetadataItem for field ${booleanField.id}`,
);
continue;
}

// Could be done via a batch update but it's safer in this context to run it sequentially with the ALTER TABLE
Expand Down
Loading