feat: enable removing all links from the field #6185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
- Enabled removal of all links, including the primary one (
packages/twenty-front/src/modules/object-record/record-field/meta-types/input/components/LinksFieldInput.tsx) - Introduced
handleDeleteClickto manage link deletion and dropdown closure (packages/twenty-front/src/modules/object-record/record-field/meta-types/input/components/LinksFieldMenuItem.tsx) - Updated URL validation schema to accept empty strings (
packages/twenty-front/src/utils/validation-schemas/absoluteUrlSchema.ts)
3 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
There was a problem hiding this comment.
PR Summary
(updates since last review)
- Replaced error throws with logging statements and continued loop (
packages/twenty-server/src/database/commands/upgrade-version/0-22/0-22-update-boolean-fields-null-default-values-and-null-values.command.ts)
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
There was a problem hiding this comment.
PR Summary
(updates since last review)
- Removed test case for empty string as invalid URL (
packages/twenty-front/src/utils/validation-schemas/__tests__/absoluteUrlSchema.test.ts) - Potentially allows empty strings as valid URLs
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
FelixMalfait
approved these changes
Jul 10, 2024
|
Failing test is not related to this PR, cf https://github.com/twentyhq/twenty/actions/runs/9857499711/job/27216712049 |
|
Thanks @rostaklein for your contribution! |
Faisal-imtiyaz123
pushed a commit
to Faisal-imtiyaz123/twenty
that referenced
this pull request
Jul 10, 2024
closes twentyhq#6041 - enabled removing all dropdown items including the primary one - primary one can be removed even when it is not the last remaining one from the list, this will set the next item on the list as the new primary one (_idk if it was expected to implement this_) https://github.com/twentyhq/twenty/assets/19856731/405a055d-13de-43f4-b3e8-d6a199bfdf24 --------- Co-authored-by: Félix Malfait <[email protected]>
Faisal-imtiyaz123
pushed a commit
to Faisal-imtiyaz123/twenty
that referenced
this pull request
Jul 10, 2024
closes twentyhq#6041 - enabled removing all dropdown items including the primary one - primary one can be removed even when it is not the last remaining one from the list, this will set the next item on the list as the new primary one (_idk if it was expected to implement this_) https://github.com/twentyhq/twenty/assets/19856731/405a055d-13de-43f4-b3e8-d6a199bfdf24 --------- Co-authored-by: Félix Malfait <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #6041
Screen.Recording.2024-07-09.at.22.50.24.mov