Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance Dropdown API to make portal usage optional #6182

Merged
merged 1 commit into from
Jul 9, 2024

Conversation

charlesBochet
Copy link
Member

Using a portal in dropdown systematically can be an issue in case we are having dropdown within dropdown. The useClickOutside listener will be triggered. It's easier to usePortal only in the case we really need them, which is quite rare

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

  • Deleted packages/twenty-front/src/modules/object-record/record-table/constants/ColumnHeadDropdownId.ts
  • Added usePortal prop to StyledDropdown in packages/twenty-front/src/modules/object-record/record-table/record-table-header/components/RecordTableColumnHeadWithDropdown.tsx
  • Introduced usePortal prop in packages/twenty-front/src/modules/ui/layout/dropdown/components/Dropdown.tsx to conditionally use FloatingPortal

3 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings

@Weiko Weiko merged commit 9683a19 into main Jul 9, 2024
12 of 13 checks passed
@Weiko Weiko deleted the fix-kanban-creation-issue branch July 9, 2024 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants