Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix contact creation and rename email aliases to handle aliases #6176

Merged
merged 2 commits into from
Jul 9, 2024

Conversation

bosiraphael
Copy link
Contributor

Fix contact creation (linked to #6162) and rename email aliases to handle aliases

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

  • Renamed emailAliases to handleAliases in mock data for SettingsAccountsCalendars.stories.tsx and SettingsAccountsEmails.stories.tsx
  • Updated CONNECTED_ACCOUNT_STANDARD_FIELD_IDS in standard-field-ids.ts to use handleAliases
  • Modified filter-out-contacts-from-company-or-workspace.util.ts to reflect handleAliases
  • Renamed methods and variables in google-email-alias-manager.service.ts and email-alias-manager.service.ts to handleAliases
  • Updated ConnectedAccountRepository and connected-account.workspace-entity.ts to use handleAliases
  • Changed messaging-message.service.ts and messaging-gmail-messages-import.service.ts to use handleAliases in message direction logic and method names

11 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings

@charlesBochet charlesBochet merged commit 2838700 into main Jul 9, 2024
13 of 14 checks passed
@charlesBochet charlesBochet deleted the rename-email-aliases-to-handle-aliases branch July 9, 2024 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants