Display table record creation row when clicking on Add new from table empty state #6174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
packages/twenty-front/src/modules/object-record/record-table/components/RecordTableWithWrappers.tsx: Added check forpendingRecordIdto conditionally renderRecordTableEmptyState.packages/twenty-front/src/pages/object-record/RecordIndexPage.tsx: AddedhandleAddButtonClickfunction to handle new record creation from the empty state.packages/twenty-front/src/pages/object-record/RecordIndexPage.tsx: Reordered import statements.
2 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
There was a problem hiding this comment.
PR Summary
(updates since last review)
packages/twenty-front/src/modules/object-record/record-table/components/RecordTable.tsx: Display table record creation row on 'Add new' click from empty state.packages/twenty-front/src/modules/object-record/record-table/components/RecordTableContextProvider.tsx: ReplaceduseUpsertRecordV2withuseUpsertRecord.packages/twenty-front/src/modules/object-record/record-table/components/RecordTableWithWrappers.tsx: Always displayRecordTablecomponent, removing conditional rendering ofRecordTableEmptyState.packages/twenty-front/src/modules/object-record/record-table/record-table-cell/hooks/useUpsertRecord.ts: Refactored upsert logic to use Recoil callbacks and snapshot values.packages/twenty-front/src/modules/object-record/record-table/record-table-cell/hooks/useUpsertRecordV2.ts: Deleted file, consolidating upsert functionality.
5 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
There was a problem hiding this comment.
PR Summary
(updates since last review)
packages/twenty-front/jest.config.ts: Set 'silent' option to false for detailed logging during test runs.packages/twenty-front/src/modules/object-record/record-table/record-table-cell/hooks/__tests__/useUpsertRecord.test.tsx: Updated test cases to align with newuseUpsertRecordhook signature requiringobjectNameSingularparameter.packages/twenty-front/src/modules/object-record/record-table/record-table-cell/hooks/__tests__/useUpsertRecord.test.tsx: Refactored tests for better maintainability by injecting state values more cleanly.
2 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
There was a problem hiding this comment.
PR Summary
(updates since last review)
packages/twenty-front/jest.config.ts: Setsilentmode totrueto suppress Jest's output logs during test runs.
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per title