Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Data explorer #6159
Data explorer #6159
Changes from 9 commits
21cbb4f
a5d97fb
0b51b48
80ae167
ee43744
388a062
0c6e7a4
398598c
d9dee57
1e42afe
165f508
2566c14
f228dad
3348509
ce29c62
22f1991
22a3f80
215dc40
09b4608
70602a6
5154b1c
64904c6
d0a0749
82b3a20
1f18757
b3dcbb2
035f9e6
711c84a
9a02410
cb617c9
9bed28e
b1b2aee
27ad5c6
4239bed
6bb7bfa
7fc799b
f0f4d70
78d073f
3400414
ced9a6d
fc8ab76
ef059b1
90704b1
d2cf9d2
1f5c8eb
957dd54
66e3f9b
1c637af
c2cbf95
5462df2
2dd88c0
d12c034
2dc3d89
97368cd
199b4da
94fa77a
bc3963b
d1442c3
86deef6
efa4a24
8aaaffc
dfb501a
ffe3661
3621a22
19e10ad
e41dc25
f8e591f
f1fa4a2
aa651b1
9bce68b
27bee2a
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧠 logic: Consider adding error handling for the report creation process to manage potential failures.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🪶 style: Consider removing this commented-out line if it's not needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🪶 style: Destructure props for better readability and to avoid repetitive
props.
usage.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧠 logic: No need to check
props.reports
before checkingprops.reports.length > 0
sinceprops.reports
is typed asReport[]
and will always be defined.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🪶 style: Consider memoizing the
groupReports
calculation to optimize performance.