Basic import for select in CSV

[FelixMalfait]

Enables basic support for Select import and field matching in CSV.
It's not pretty! But it's better than what we had before.
We should iterate on that quickly

[greptile-apps]

PR Summary

• Added support for importing and matching 'Select' fields in CSV
• Updated templateFields to handle 'Select' field types and options
• Enhanced ValidationStep to support matchedSelect and matchedSelectOptions
• Improved setColumn to handle different field types (select, checkbox, input)
• Commented out width property in DropdownMenu for better select support

_{4 file(s) reviewed, 2 comment(s)
Edit PR Review Bot Settings}

[greptile-apps]

🪶 style: Consider optimizing the filter and length comparison for better performance.

[greptile-apps]

🧠 logic: Potential issue if fieldOptions is undefined. Ensure fieldOptions is always defined or handle the case when it's not.

[Weiko]

Haven't tested the functionality yet but code LGTM! CI is failing on one of the tests 🙂 @FelixMalfait

[Weiko]

For more clarity? Wdyt? Not sure haha

      generateColumns(fields)
        .map((column) => {
          const isColumnMatched = (
            importColumn: Column<string>,
            columnKey: string,
          ): boolean => {
            const matchTypes = [
              ColumnType.matched,
              ColumnType.matchedSelect,
              ColumnType.matchedSelectOptions,
            ];

            return (
              matchTypes.includes(importColumn.type) &&
              importColumn.value === columnKey
            );
          };

          const hasBeenImported = importedColumns.some(
            (importColumn) =>
              isColumnMatched(importColumn, column.key) ||
              column.key === 'select-row',
          );

          if (!hasBeenImported && !showUnmatchedColumns) return null;
          return column;
        })

[FelixMalfait]

Much nicer 😍 thanks

[FelixMalfait]

Not sure if I'm missing something but I feel like often when I try to do these kind of optimizations then Typescript gets lost

[FelixMalfait]

Initially I had tried this but it was the same

[Weiko]

Why removing the switch case pattern here? If it's too big maybe we can split the code inside functions?

[FelixMalfait]

Tbh I'm not sure why but the switch/case caused a wired typescript issue which I didn't figure out

[greptile-apps]

PR Summary

(updates since last review)

• Enhanced setColumn function to handle 'select' field types
• Updated setColumn.test.ts to check for matchedSelectOptions
• Improved field matching in MatchColumnsStep and ValidationStep components

_{1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings}